VC-32829 / Consolidates Cloud ID, Adds ability to specify ARN in Provisioning and Adds Provisioning cucumber tests for AWS #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
luispresuelVenafi
commented
Jun 5, 2024
luispresuelVenafi
commented
- Changes output in CLI to unify returned ID's from providers in Cloud ID.
- Provides ability to provider ARN in VCert SDK, and as well we add ARN flag in VCert CLI.
- Adds AWS Cloud Provider testing for provisioning in cucumber tests and also refactors code accordingly.
- Adds AWS client to delete certificate after certificate is provisioned afterward
luispresuelVenafi
requested review from
tr1ck3r,
rvelaVenafi,
marcos-albornoz and
EduardoVV
as code owners
luispresuelVenafi
force-pushed
the
VC-32829/cucumber-tests-for-provisioning-2
branch
from
f0a908c
to
02ed1eb
Compare
…ID. Provides ability to provider ARN as well adds ARN flag in CLI. Adds AWS Cloud Provider testing for provisioning in cucumber tests and also refactors code accordingly. Adds AWS client to delete certificate after certificate is provisioned afterward
luispresuelVenafi
force-pushed
the
VC-32829/cucumber-tests-for-provisioning-2
branch
from
02ed1eb
to
ab03020
Compare
marcos-albornoz
approved these changes
Jun 6, 2024
rvelaVenafi
approved these changes
Jun 6, 2024
luispresuelVenafi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.