Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Github Release Tool #537

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Conversation

luispresuelVenafi
Copy link
Contributor

Making the pipeline github release tool version static until we bump Vcert to Golang v1.23, as currenlty, our pipeline running always latest, throw us error:

[2024-11-07T16:53:09.909Z] echo '```' >> release.txt
[2024-11-07T16:53:09.909Z] go install github.com/tcnksm/ghr@latest
[2024-11-07T16:53:22.070Z] go: downloading github.com/tcnksm/ghr v0.17.0
[2024-11-07T16:53:22.070Z] go: github.com/tcnksm/ghr@latest: github.com/tcnksm/ghr@v0.17.0 requires go >= 1.23 (running go 1.21.8; GOTOOLCHAIN=local)
[2024-11-07T16:53:22.070Z] make: *** [Makefile:123: release] Error 1

Looking at the Github project here, we can see that from 0.16.2 to 0.17.0 version, they bumped golang from version 1.19 to 1.23. Hence, we are making our pipeline static to the version 0.16.2, until we bump Go version up to 1.23

References:

@luispresuelVenafi luispresuelVenafi changed the title Github Releaste Tool Fix Fix: Github Release Tool Nov 11, 2024
@luispresuelVenafi luispresuelVenafi merged commit 5e219b3 into master Nov 12, 2024
3 checks passed
@luispresuelVenafi luispresuelVenafi deleted the pipeline-github-release-tool-fix branch November 12, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants