Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protein Comparison via Model Overlaying using TM Align #192

Merged
merged 16 commits into from
Mar 10, 2024
Merged

Conversation

ansengarvin
Copy link
Collaborator

@ansengarvin ansengarvin commented Mar 4, 2024

Added ability to compare protein models by overlaying, aligning, and coloring their models. Accomplished by merging the two PDB files into a single PDB file using TM Align. This can be done with the new API endpoint /proteins/pdb/:proteinA/:proteinB

Created a rudimentary web page for comparing proteins, at compare/ProteinA/ProteinB:
Protein Comparison:
image

Added "compare" links to the computed insights field, to allow the user to quickly compare similar proteins:
image

Added two new shell commands to install and remove TM Align in docker:
image

@ansengarvin ansengarvin changed the title Protein Comparison via Model Overlaying with TM Align Protein Comparison via Model Overlaying using TM Align Mar 4, 2024
@ansengarvin ansengarvin marked this pull request as ready for review March 10, 2024 17:48
@ansengarvin ansengarvin marked this pull request as draft March 10, 2024 17:49
@ansengarvin ansengarvin marked this pull request as ready for review March 10, 2024 17:57
@xnought xnought self-requested a review March 10, 2024 19:59
Comment on lines 68 to 69
# stdout = bash_cmd(cmd)
# log.warn(stdout)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like you accidentally commented out the lines that actually run TMalign

@xnought
Copy link
Member

xnought commented Mar 10, 2024

One way to get around the TMaligns creating files issue is to create a new directory every time. Then run TMalign, read in the file stream as bytes into RAM, and returning that to the user. See the FASTA endpoint for how to return bytes as a file.

Then since we read in the file as bytes we are free to remove the files from the file system. I can help out on this.

Copy link
Member

@xnought xnought left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Real good work! I'll merge stuff in. Make sure to create an issue on the TMalgin file generation issue so we can revise that next term @ansengarvin.

Overall, very nice.

@xnought xnought merged commit ac36b17 into main Mar 10, 2024
2 checks passed
@xnought xnought deleted the molstar_superpose branch March 10, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants