Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: infinite scroll on protein search page #256

Merged
merged 6 commits into from
May 1, 2024
Merged

feat: infinite scroll on protein search page #256

merged 6 commits into from
May 1, 2024

Conversation

xnought
Copy link
Member

@xnought xnought commented Apr 30, 2024

Instead of restyling the pagination, I opted to do infinite scroll instead.

When user scrolls down far enough, requests next page of proteins to simulate infinite scroll.

I added a new package so make sure to ./run.sh refresh_packages.

Screen.Recording.2024-04-29.at.7.19.08.PM.mov

closes #250

Copy link
Collaborator

@ansengarvin ansengarvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it, and everything looks good to me! Infinite scroll is much better than having to press next page. I'll merge this in.

@ansengarvin ansengarvin merged commit 0110543 into main May 1, 2024
2 checks passed
@xnought xnought deleted the inf branch May 23, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restyle the paging to show (prev) 1...n (next) sort of like google
2 participants