Add icon to executable

Veras-D · Dec 30, 2023 · 74e1866 · 74e1866
1 parent c06676d
commit 74e1866
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -38,7 +38,7 @@ jobs:
  pip install pyinstaller
 
  - name: Build with pyinstaller for ${{ matrix.config.os }}
- run: pyinstaller scripts/main.py --onefile --noconsole
+ run: pyinstaller scripts/main.py --onefile --noconsole --icon=img/icon.ico
 
  - name: Rename builded app
  run: mv ./dist ./dist-${{ matrix.config.os }}

diff --git a/img/icon.ico b/img/icon.ico
diff --git a/scripts/main.py b/scripts/main.py
@@ -140,8 +140,8 @@ def led_pulse():
 root.geometry("300x120")
 root.resizable(False, False)
 ctk.set_appearance_mode("dark")
-icon = get_base64_encoded_image("../img/icon.png")
-root.iconphoto(True, PhotoImage(data=icon))
+# icon = get_base64_encoded_image("../img/icon.png")
+# root.iconphoto(True, PhotoImage(data=icon))
 
 
 selected_port = StringVar()

diff --git a/scripts/utilities.py b/scripts/utilities.py
@@ -2,7 +2,7 @@
 import serial.tools.list_ports
 from tkinter import *
 import webbrowser
-import base64
+# import base64
 
 
 arduino = None
@@ -12,9 +12,9 @@ def callback(url):
  webbrowser.open_new_tab(url)
 
 
-def get_base64_encoded_image(image_path):
- with open(image_path, "rb") as img_file:
- return base64.b64encode(img_file.read()).decode('utf-8')
+# def get_base64_encoded_image(image_path):
+#  with open(image_path, "rb") as img_file:
+#  return base64.b64encode(img_file.read()).decode('utf-8')
 
 
 def find_arduino():