Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vmalert): discover vmalertmanagers #703

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(vmalert): discover vmalertmanagers #703

wants to merge 1 commit into from
+466 −266

Conversation

uhthomas
Copy link

@uhthomas uhthomas commented Jul 24, 2023 •
edited
Loading

Related: #702

@uhthomas uhthomas changed the title fix(vmalert): correctly remove notifiers without a selector fix(vmalert): discover vmalertmanagers Jul 24, 2023
@uhthomas uhthomas marked this pull request as draft July 24, 2023 22:06
@uhthomas uhthomas marked this pull request as ready for review July 24, 2023 22:17
@uhthomas
Copy link
Author

Upon further thinking and reading, I'm not sure it will fix the linked issue. However, it definitely does address some problematic assumptions made by the original filtering code. There are a few scenarios where it will do the complete wrong thing, which isn't ideal.

@uhthomas uhthomas force-pushed the 702 branch 4 times, most recently from 223d55f to 834b122 Compare July 24, 2023 22:26
@Haleygo
Copy link
Contributor

Haleygo commented Jul 26, 2023

Upon further thinking and reading, I'm not sure it will fix the linked issue. However, it definitely does address some problematic assumptions made by the original filtering code. There are a few scenarios where it will do the complete wrong thing, which isn't ideal.

Thanks for the pr!
Can you add some scenarios that could be wrong for the origin code in the test file?

@uhthomas
Copy link
Author

@Haleygo Will do.

@f41gh7 f41gh7 requested review from Amper and Haleygo August 10, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amper Amper Awaiting requested review from Amper

@Haleygo Haleygo Awaiting requested review from Haleygo Haleygo is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uhthomas @Haleygo