Fix cloning did not correctly apply all previous values

VincentChalnot · Jan 22, 2020 · 81914fa · 81914fa
1 parent dff65df
commit 81914fa
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/Entity/AbstractData.php b/Entity/AbstractData.php
@@ -874,8 +874,7 @@ public function __clone()
         $this->__construct($this->getFamily());
 
         foreach ($newValues as $newValue) {
-            $this->values->add($newValue);
-            $newValue->setData($this);
+            $this->addValue($newValue);
         }
     }
 

diff --git a/Entity/AbstractValue.php b/Entity/AbstractValue.php
@@ -560,9 +560,6 @@ public function __clone()
     {
         $this->id = null;
         $attribute = $this->getAttribute();
-        if ($this->dataValue && $attribute->getType()->isEmbedded()) {
-            $this->dataValue = clone $this->dataValue;
-        }
     }
 
     /**