Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support of non-default shopping cart (cart by cartId) #1453

Open
wants to merge 14 commits into
base: dev
Choose a base branch
from

Conversation

asvishnyakov
Copy link
Collaborator

@asvishnyakov asvishnyakov commented Nov 15, 2024

Description

Checkout & Cart pages, useFullCart composable and GetFullCartQuery now can be reused with any custom cart (it accept cartId)

Custom cart

Possible regression

  • Default cart should be opened and loaded successfully, including cases when you go to/from non-default cart

References

Jira-link:

Artifact URL:

https://vc3prerelease.blob.core.windows.net/packages/vc-theme-b2b-vue-2.11.0-pr-1453-3829-3829099c.zip

@asvishnyakov asvishnyakov changed the title feat: non-default shopping cart feat: non-default shopping cart (cart by cartId) Nov 15, 2024
@asvishnyakov asvishnyakov changed the title feat: non-default shopping cart (cart by cartId) feat: support of non-default shopping cart (cart by cartId) Nov 15, 2024
@asvishnyakov asvishnyakov marked this pull request as ready for review November 19, 2024 17:54
@asvishnyakov asvishnyakov requested a review from a team as a code owner November 19, 2024 17:54
@asvishnyakov asvishnyakov reopened this Nov 21, 2024
@asvishnyakov asvishnyakov changed the base branch from feat/more-graphql-merge-composables to dev November 21, 2024 17:10
client-app/pages/cart.vue Outdated Show resolved Hide resolved
client-app/pages/checkout/index.vue Show resolved Hide resolved
Copy link

sonarcloud bot commented Nov 27, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants