-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support of non-default shopping cart (cart by cartId) #1453
Open
asvishnyakov
wants to merge
14
commits into
dev
Choose a base branch
from
feat/custom-cart
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asvishnyakov
changed the title
feat: non-default shopping cart
feat: non-default shopping cart (cart by cartId)
Nov 15, 2024
asvishnyakov
changed the title
feat: non-default shopping cart (cart by cartId)
feat: support of non-default shopping cart (cart by cartId)
Nov 15, 2024
asvishnyakov
requested review from
Andrew-Orlov,
goldenmaya,
ivan-kalachikov and
NaMax66
November 15, 2024 12:36
asvishnyakov
changed the base branch from
feat/more-graphql-merge-composables
to
dev
November 21, 2024 17:10
NaMax66
requested changes
Nov 26, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checkout
&Cart
pages,useFullCart
composable andGetFullCartQuery
now can be reused with any custom cart (it acceptcartId
)Possible regression
References
Jira-link:
Artifact URL:
https://vc3prerelease.blob.core.windows.net/packages/vc-theme-b2b-vue-2.11.0-pr-1453-3829-3829099c.zip