VCST-1982: Export sitemap to store assets #111
Annotations
11 warnings
|
Build
/home/runner/work/vc-module-sitemaps/vc-module-sitemaps/src/VirtoCommerce.SitemapsModule.Data/BackgroundJobs/SitemapProcessJob.cs(37,31): warning S109: Assign this magic number '10' to a well-named variable or constant, and use that instead. (https://rules.sonarsource.com/csharp/RSPEC-109) [/home/runner/work/vc-module-sitemaps/vc-module-sitemaps/src/VirtoCommerce.SitemapsModule.Data/VirtoCommerce.SitemapsModule.Data.csproj]
|
|
Build
/home/runner/work/vc-module-sitemaps/vc-module-sitemaps/src/VirtoCommerce.SitemapsModule.Data/BackgroundJobs/SitemapProcessJob.cs(58,34): warning S4457: Split this method into two, one handling parameters check and the other handling the asynchronous code. (https://rules.sonarsource.com/csharp/RSPEC-4457) [/home/runner/work/vc-module-sitemaps/vc-module-sitemaps/src/VirtoCommerce.SitemapsModule.Data/VirtoCommerce.SitemapsModule.Data.csproj]
|
|
Build
/home/runner/work/vc-module-sitemaps/vc-module-sitemaps/src/VirtoCommerce.SitemapsModule.Data/Services/SitemapXmlGenerator.cs(49,56): warning S4457: Split this method into two, one handling parameters check and the other handling the asynchronous code. (https://rules.sonarsource.com/csharp/RSPEC-4457) [/home/runner/work/vc-module-sitemaps/vc-module-sitemaps/src/VirtoCommerce.SitemapsModule.Data/VirtoCommerce.SitemapsModule.Data.csproj]
|
|
Build
/home/runner/work/vc-module-sitemaps/vc-module-sitemaps/src/VirtoCommerce.SitemapsModule.Data/Services/SitemapXmlGenerator.cs(113,25): warning S1854: Remove this useless assignment to local variable 'requiredItems'. (https://rules.sonarsource.com/csharp/RSPEC-1854) [/home/runner/work/vc-module-sitemaps/vc-module-sitemaps/src/VirtoCommerce.SitemapsModule.Data/VirtoCommerce.SitemapsModule.Data.csproj]
|
|
Build
/home/runner/work/vc-module-sitemaps/vc-module-sitemaps/src/VirtoCommerce.SitemapsModule.Data/Services/SitemapXmlGenerator.cs(123,25): warning S3458: Remove this empty 'case' clause. (https://rules.sonarsource.com/csharp/RSPEC-3458) [/home/runner/work/vc-module-sitemaps/vc-module-sitemaps/src/VirtoCommerce.SitemapsModule.Data/VirtoCommerce.SitemapsModule.Data.csproj]
|
|
Build
/home/runner/work/vc-module-sitemaps/vc-module-sitemaps/src/VirtoCommerce.SitemapsModule.Data.SqlServer/Migrations/20000000000000_UpdateSitemapsV2.cs(16,33): warning S1186: Add a nested comment explaining why this method is empty, throw a 'NotSupportedException' or complete the implementation. (https://rules.sonarsource.com/csharp/RSPEC-1186) [/home/runner/work/vc-module-sitemaps/vc-module-sitemaps/src/VirtoCommerce.SitemapsModule.Data.SqlServer/VirtoCommerce.SitemapsModule.Data.SqlServer.csproj]
|
|
Build
/home/runner/work/vc-module-sitemaps/vc-module-sitemaps/src/VirtoCommerce.SitemapsModule.Web/Controllers/Api/SitemapsModuleApiController.cs(64,43): warning S107: Constructor has 11 parameters, which is greater than the 7 authorized. (https://rules.sonarsource.com/csharp/RSPEC-107) [/home/runner/work/vc-module-sitemaps/vc-module-sitemaps/src/VirtoCommerce.SitemapsModule.Web/VirtoCommerce.SitemapsModule.Web.csproj]
|
|
Build
/home/runner/work/vc-module-sitemaps/vc-module-sitemaps/src/VirtoCommerce.SitemapsModule.Web/Controllers/Api/SitemapsModuleApiController.cs(163,41): warning S4144: Update this method so that its implementation is not identical to 'AddSitemap'. (https://rules.sonarsource.com/csharp/RSPEC-4144) [/home/runner/work/vc-module-sitemaps/vc-module-sitemaps/src/VirtoCommerce.SitemapsModule.Web/VirtoCommerce.SitemapsModule.Web.csproj]
|
|
Build
/home/runner/work/vc-module-sitemaps/vc-module-sitemaps/src/VirtoCommerce.SitemapsModule.Data/BackgroundJobs/SitemapProcessJob.cs(37,31): warning S109: Assign this magic number '10' to a well-named variable or constant, and use that instead. (https://rules.sonarsource.com/csharp/RSPEC-109) [/home/runner/work/vc-module-sitemaps/vc-module-sitemaps/src/VirtoCommerce.SitemapsModule.Data/VirtoCommerce.SitemapsModule.Data.csproj]
|
|
Build
/home/runner/work/vc-module-sitemaps/vc-module-sitemaps/src/VirtoCommerce.SitemapsModule.Data/BackgroundJobs/SitemapProcessJob.cs(58,34): warning S4457: Split this method into two, one handling parameters check and the other handling the asynchronous code. (https://rules.sonarsource.com/csharp/RSPEC-4457) [/home/runner/work/vc-module-sitemaps/vc-module-sitemaps/src/VirtoCommerce.SitemapsModule.Data/VirtoCommerce.SitemapsModule.Data.csproj]
|
|
Get Changelog
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Loading