Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VCST-1438: Fix 32/64 bit conflict when copying DLL files #2811

Merged
merged 17 commits into from
Jul 1, 2024
Merged

Conversation

basilkot
Copy link
Contributor

@basilkot basilkot commented Jun 26, 2024

Description

  • extract source and target dlls checking to separate interface
  • tests this interface implementation logic

References

QA-test:

Jira-link:

https://virtocommerce.atlassian.net/browse/VCST-1438

Artifact URL:

Image tag:
3.838.0-pr-2811-f237-vcst-1438-f23723d3

@vc-ci
Copy link
Contributor

vc-ci commented Jun 26, 2024

Reveiw task created: https://virtocommerce.atlassian.net/browse/VCST-1443

@artem-dudarev artem-dudarev changed the title copy dll files refactoring and unit tests VCST-1438: Fix 32/64 bit conflict when copying DLL files Jun 29, 2024
Copy link

sonarcloud bot commented Jul 1, 2024

@basilkot basilkot merged commit e7dc6b4 into dev Jul 1, 2024
8 checks passed
@basilkot basilkot deleted the fix/VCST-1438 branch July 1, 2024 14:08
basilkot added a commit that referenced this pull request Jul 1, 2024
Co-authored-by: Oleg Zhuk <zhukoo@gmail.com>
Co-authored-by: artem-dudarev <ad@virtoway.com>
basilkot added a commit that referenced this pull request Jul 1, 2024
Co-authored-by: Oleg Zhuk <zhukoo@gmail.com>
Co-authored-by: artem-dudarev <ad@virtoway.com>

# Conflicts:
#	src/VirtoCommerce.Platform.Modules/Local/LocalStorageModuleCatalog.cs
OlegoO added a commit that referenced this pull request Jul 3, 2024
Co-authored-by: Oleg Zhuk <zhukoo@gmail.com>
Co-authored-by: artem-dudarev <ad@virtoway.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants