Merge pull request #377 from aXenDeveloper/fix/mail_config

fix(mail): Create empty config mail when doesn't exists
VitNode · Jun 11, 2024 · c68605a · c68605a
2 parents b2658bd + b39f574
commit c68605a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 10 deletions.
diff --git a/backend/src/plugins/core/admin/email/mail.service.ts b/backend/src/plugins/core/admin/email/mail.service.ts
@@ -28,6 +28,19 @@ export class MailService {
   private readonly transporter: nodemailer.Transporter;
 
   constructor() {
+    if (!fs.existsSync(this.path)) {
+      // Create a default config file
+      fs.writeFileSync(
+        this.path,
+        JSON.stringify({
+          smtp_host: "",
+          smtp_user: "",
+          smtp_secure: false,
+          smtp_port: 587
+        })
+      );
+    }
+
     const data = fs.readFileSync(this.path, "utf-8");
     const config: ShowAdminEmailSettingsServiceObjWithPassword =
       JSON.parse(data);

diff --git a/backend/src/plugins/core/admin/email/settings/show/show.service.ts b/backend/src/plugins/core/admin/email/settings/show/show.service.ts
@@ -14,16 +14,6 @@ export class ShowAdminEmailSettingsService extends HelpersAdminEmailSettingsServ
       settings: { email: emailSettings }
     } = getConfigFile();
 
-    if (!fs.existsSync(this.path)) {
-      return {
-        smtp_host: "",
-        smtp_user: "",
-        smtp_secure: false,
-        smtp_port: 587,
-        ...emailSettings
-      };
-    }
-
     const read = fs.readFileSync(this.path, "utf-8");
     const config: ShowAdminEmailSettingsServiceObj = JSON.parse(read);