Fixes #152 #171
Open
Fixes #152 #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Our team will soon review your PR. Thanks @sarkartanmay393 :) |
|
@Lalit3716 Check this out Lalit. |
Lalit3716
requested changes
Mar 12, 2023
There was a problem hiding this comment.
Great work on this @sarkartanmay393, please address the change I have mentioned, Thanks!
| export const topics = topicsData.sort((a, b) => a.value - b.value); | ||
|
|
||
| export const shuffleTopics = shuffleArray(topicsData); | ||
| export const shuffleTopics = shuffleArray(await getTopics()); |
There was a problem hiding this comment.
Don't use top-level awaits because it may not be supported in some old browsers and hence the checks on this PR are failing.
Try to come up with something that does not involve top-level awaits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed all topics from
/client/src/data/topics.ts, and created a function to load all topics data from the backend database. I called this URL/api/get-topicsand got all topics data, then returned that data from my function. And Finally, switch the source of all by tweaking a little.@Lalit3716 It is working fine on my machine, kindly review it.