Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PHP 8.3 #455

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Support PHP 8.3 #455

merged 3 commits into from
Dec 13, 2023

Conversation

deleugpn
Copy link
Contributor

Description

Support PHP 8.3

Motivation and Context

Use new PHP version

How Has This Been Tested?

It hasn't yet, hopefully the pull request will trigger automation tests.

Example Output or Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Basic version maintenance

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@SecondeJK SecondeJK self-assigned this Nov 27, 2023
@SecondeJK SecondeJK added enhancement release-candidate This PR will result in a release labels Nov 27, 2023
@dragonmantank
Copy link
Contributor

We are currently waiting on some updates for Prophecy to make it's way through their libraries (Prophecy has a patch, was waiting for official 8.3 release, and then the phpunit-prophecy bridge should update). Once those are updated we'll be able to update our library officially to 8.3.

I updated the testing matrix in this PR to also drag in 8.3, so we can re-run and merge this once the underlying libraries are updated.

@SecondeJK SecondeJK mentioned this pull request Dec 12, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (bac6ebc) 78.94% compared to head (2695093) 79.01%.
Report is 2 commits behind head on main.

Files Patch % Lines
src/Verify2/VerifyObjects/VerificationWorkflow.php 75.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #455      +/-   ##
============================================
+ Coverage     78.94%   79.01%   +0.07%     
- Complexity     2331     2337       +6     
============================================
  Files           218      218              
  Lines          6264     6281      +17     
============================================
+ Hits           4945     4963      +18     
+ Misses         1319     1318       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deleugpn
Copy link
Contributor Author

hey @dragonmantank I just ran all tests on my local machine against PHP 8.3.0 and tests are passing.

Could you please approve the workflow and let me know what else we need to unlock this? I would like to update my project and Vonage is the only pending dependency not supporting PHP 8.3 yet.

image

@pardel pardel requested a review from SecondeJK December 13, 2023 15:03
@SecondeJK
Copy link
Contributor

I've approved the run, but not looked if prophecy is updated. I suspect we're close to merging this.

Copy link
Contributor

@SecondeJK SecondeJK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8.3 is now passing, so we can now bump other deps causing issues like JWT

@SecondeJK
Copy link
Contributor

OK let's go.

@SecondeJK SecondeJK merged commit dcd9651 into Vonage:main Dec 13, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement release-candidate This PR will result in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants