-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support PHP 8.3 #455
Support PHP 8.3 #455
Conversation
f5b9f74
to
5f70952
Compare
We are currently waiting on some updates for Prophecy to make it's way through their libraries (Prophecy has a patch, was waiting for official 8.3 release, and then the phpunit-prophecy bridge should update). Once those are updated we'll be able to update our library officially to 8.3. I updated the testing matrix in this PR to also drag in 8.3, so we can re-run and merge this once the underlying libraries are updated. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #455 +/- ##
============================================
+ Coverage 78.94% 79.01% +0.07%
- Complexity 2331 2337 +6
============================================
Files 218 218
Lines 6264 6281 +17
============================================
+ Hits 4945 4963 +18
+ Misses 1319 1318 -1 ☔ View full report in Codecov by Sentry. |
hey @dragonmantank I just ran all tests on my local machine against PHP 8.3.0 and tests are passing. Could you please approve the workflow and let me know what else we need to unlock this? I would like to update my project and Vonage is the only pending dependency not supporting PHP 8.3 yet. |
I've approved the run, but not looked if prophecy is updated. I suspect we're close to merging this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8.3 is now passing, so we can now bump other deps causing issues like JWT
OK let's go. |
Description
Support PHP 8.3
Motivation and Context
Use new PHP version
How Has This Been Tested?
It hasn't yet, hopefully the pull request will trigger automation tests.
Example Output or Screenshots (if appropriate):
Types of changes
Checklist: