Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanups in featurization #35

Merged
merged 8 commits into from
Nov 16, 2023

Conversation

ataymano
Copy link
Member

  • ":=" -> "=" for vw formatting
  • moving context and action extraction back to featurizer

@@ -157,11 +140,29 @@ def _generic_namespaces(context, actions):
for a in actions:
a["#"] = PickBestFeaturizer._generic_namespace(a)

def get_context_actions(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Suggested change
def get_context_actions(
def get_context_and_actions(

@ataymano ataymano merged commit 4aee78d into VowpalWabbit:main Nov 16, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants