Directly use Og syscall to optimise some property accessor uses

Properties with descriptors (setters/getters) and builtin properties will still be looked up via `#core:getProperty`.

dist/libvoxel.h

@@ -1468,10 +1468,13 @@ void voxel_builtins_core_getObjectItem(voxel_Executor* executor) {
     voxel_Thing* key = voxel_pop(executor);
     voxel_Thing* object = voxel_pop(executor);
 
-    VOXEL_REQUIRE(
-        key &&
-        VOXEL_ARG(object, VOXEL_TYPE_OBJECT)
-    );
+    if (object->type != VOXEL_TYPE_OBJECT) {
+        voxel_pushNull(executor);
+
+        goto voxel_finally;
+    }
+
+    VOXEL_REQUIRE(key);
 
     voxel_ObjectItem* objectItem = voxel_getObjectItem(object, key);
 

src/builtins/core/objects.h

@@ -14,10 +14,13 @@ void voxel_builtins_core_getObjectItem(voxel_Executor* executor) {
     voxel_Thing* key = voxel_pop(executor);
     voxel_Thing* object = voxel_pop(executor);
 
-    VOXEL_REQUIRE(
-        key &&
-        VOXEL_ARG(object, VOXEL_TYPE_OBJECT)
-    );
+    if (object->type != VOXEL_TYPE_OBJECT) {
+        voxel_pushNull(executor);
+
+        goto voxel_finally;
+    }
+
+    VOXEL_REQUIRE(key);
 
     voxel_ObjectItem* objectItem = voxel_getObjectItem(object, key);
 

tools/vxbuild-js/coreparts.js

@@ -605,4 +605,10 @@ builtinProps["W"]["deref"] = `
     return function() {
         return syscall Wd(thing);
     };
-`;
+`;
+
+export var builtinPropNames = ["weak"];
+
+Object.keys(builtinProps).forEach(function(type) {
+    Object.keys(builtinProps[type]).forEach((property) => builtinPropNames.push(property));
+});

tools/vxbuild-js/expressions.js

@@ -7,6 +7,7 @@ import * as dce from "./dce.js";
 import * as parser from "./parser.js";
 import * as statements from "./statements.js";
 import * as staticMacros from "./staticmacros.js";
+import * as coreParts from "./coreparts.js";
 
 export const ALL_BINARY_OPERATOR_CODE = {
     "*": codeGen.join(
@@ -987,6 +988,10 @@ export class ClassNode extends ast.AstNode {
             instance.propertySymbols.push(namespaces.Symbol.generateForProperty(propertyToken.value, retain));
             instance.propertyDescriptorTypes.push(descriptorType);
 
+            if (descriptorType != null) {
+                namespaces.descriptorPropertyNames.push(propertyToken.value);
+            }
+
             if (this.maybeEat(tokens, [new ast.TokenQuery(tokeniser.AssignmentOperatorToken, "=")])) {
                 instance.expectChildByMatching(tokens, [ExpressionNode], namespace);
             } else {
@@ -1431,6 +1436,21 @@ export class PropertyAccessorNode extends ast.AstNode {
             return enumValue != null ? codeGen.number(enumValue) : codeGen.bytes(codeGen.vxcTokens.NULL);
         }
 
+        if (
+            !namespaces.descriptorPropertyNames.includes(this.propertySymbol.name) &&
+            !coreParts.builtinPropNames.includes(this.propertySymbol.name)
+        ) {
+            return codeGen.join(
+                codeGen.bytes(codeGen.vxcTokens.DUPE),
+                codeGen.number(1),
+                codeGen.systemCall("Ms"),
+                codeGen.bytes(codeGen.vxcTokens.POP),
+                this.propertySymbol.generateCode(options),
+                codeGen.number(2),
+                codeGen.systemCall("Og")
+            );
+        }
+
         return codeGen.join(
             this.propertySymbol.generateCode(options),
             codeGen.number(2),

tools/vxbuild-js/namespaces.js

@@ -19,6 +19,7 @@ export var coreNamespace = null;
 export var propertySymbols = {};
 export var propertySymbolRetainedNames = {};
 export var propertySymbolUses = [];
+export var descriptorPropertyNames = [];
 
 export class Namespace {
     constructor(sourceContainer = null, preferredId = null) {