Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔏 OAuth #3

Merged
merged 16 commits into from
Aug 8, 2024
Merged

🔏 OAuth #3

merged 16 commits into from
Aug 8, 2024

Conversation

mrharpo
Copy link
Contributor

@mrharpo mrharpo commented Aug 1, 2024

OAuth2

OAuth integration with fastapi-oauth2

Features

  • OAuth2 provider using GitHub
  • Uses cookies to store JWT user token
  • Login page
    • Login with GitHub: working
    • Login with Google: not implemented yet
  • Integrate with starlette-admin AuthProvider routes
  • Add OAuth dependency for API routes

Cleanup

Cleaned up old routes and old code

Closes #1

@mrharpo mrharpo self-assigned this Aug 1, 2024
@mrharpo mrharpo added enhancement ➕ New feature or request production 🎭 Relating to the production deployment labels Aug 1, 2024
Base automatically changed from crud to main August 5, 2024 17:59
Copy link

gitguardian bot commented Aug 5, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10235458 Triggered PostgreSQL Credentials 4dde152 organ/config.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@mrharpo mrharpo marked this pull request as ready for review August 5, 2024 21:48
@mrharpo mrharpo merged commit 3a3afde into main Aug 8, 2024
2 checks passed
@mrharpo mrharpo deleted the oauth branch August 8, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ➕ New feature or request production 🎭 Relating to the production deployment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Start Conversation and roadmap for Organ
1 participant