Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♾️ Unlimited API #218

Merged
merged 1 commit into from
Nov 19, 2024
Merged

♾️ Unlimited API #218

merged 1 commit into from
Nov 19, 2024

Conversation

mrharpo
Copy link
Contributor

@mrharpo mrharpo commented Nov 19, 2024

API llmit

Removes default WAGTAILAPI_LIMIT_MAX

Closes #217

TODO

This might affect performance eventually, so a better solution would be frontend pagination for the /exhibits and /collections routes. Then, this setting can be set to the max page limit.

@mrharpo mrharpo self-assigned this Nov 19, 2024
@mrharpo mrharpo added bug 🐛 Something isn't working production 🎭 Relating to the production deployment labels Nov 19, 2024
@mrharpo mrharpo added this to the v1.0.0 Open Vault Launch 🛰 milestone Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.82%. Comparing base (3de749e) to head (9804a9f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
+ Coverage   89.80%   89.82%   +0.01%     
==========================================
  Files          67       67              
  Lines         736      737       +1     
==========================================
+ Hits          661      662       +1     
  Misses         75       75              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@mrharpo mrharpo merged commit 1fa409d into main Nov 19, 2024
10 checks passed
@mrharpo mrharpo deleted the 217-api-limit branch November 19, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working production 🎭 Relating to the production deployment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Remove API limit
1 participant