Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#357 - Prevent login to site when site is installed in a sub directory should not cause redirect loop #368

Conversation

reygcalantaol
Copy link
Collaborator

@reygcalantaol reygcalantaol commented Mar 19, 2023

Resolves #357

Description

Testing Instructions

Create new WP installation in sub-directory (e.g If your root site is test.com, install it in test.com/wp/)
Enable Lock Access to wp-login.php
Enable Prevent site access to visitor
Access the new WP site in incognito.

Pre-review Checklist

  • Issue and pull request titles are properly formatted.
  • Acceptance criteria have been satisfied and marked in the related issue.
  • Unit tests are included (if applicable).
  • Self-review of code changes has been completed.
  • Self-review of UX changes has been completed.
  • Review has been requested from @polevaultweb.

@reygcalantaol
Copy link
Collaborator Author

@polevaultweb
To recreate the issue:

  1. Create new WP installation in sub-directory (e.g If your root site is test.com, install it in test.com/wp/)
  2. Enable Lock Access to wp-login.php
  3. Enable Prevent site access to visitor
  4. Access the new WP site in incognito.

@wp-user-manager wp-user-manager merged commit 7ccee63 into develop Nov 18, 2023
1 check failed
@wp-user-manager wp-user-manager deleted the #357-Prevent-login-to-site-when-site-is-installed-in-a-sub-directory-should-not-cause-redirect-loop branch November 18, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent login to site when site is installed in a sub directory should not cause redirect loop
3 participants