Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed text sanitization on password field. #394

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Removed text sanitization on password field. #394

merged 1 commit into from
Feb 1, 2024

Conversation

reygcalantaol
Copy link
Collaborator

Resolves #384

Description

The "sanitize_text_field" sanitization has been removed from the password field because it strips strings that are considered percent-encoded characters.

Testing Instructions

  1. In the registration page, try using either of the following for the password field:
    Password##%%1234
    Password#%1234

Pre-review Checklist

  • Issue and pull request titles are properly formatted.
  • Acceptance criteria have been satisfied and marked in the related issue.
  • Unit tests are included (if applicable).
  • Self-review of code changes has been completed.
  • Self-review of UX changes has been completed.
  • Review has been requested from @polevaultweb.

@wp-user-manager wp-user-manager merged commit 70b2a2d into develop Feb 1, 2024
1 check passed
@wp-user-manager wp-user-manager deleted the #384-Some-special-characters-are-being-deleted,-or-not-recognized-when-used-within-the-password-field branch February 1, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some special characters are being deleted, or not recognized when used within the password field
2 participants
@reygcalantaol @wp-user-manager