pr feedback

WalletConnect · Jan 29, 2024 · ff313dd · ff313dd
1 parent 1ae7197
commit ff313dd
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 16 deletions.
diff --git a/Example/DApp/Modules/Sign/SignPresenter.swift b/Example/DApp/Modules/Sign/SignPresenter.swift
@@ -54,12 +54,10 @@ final class SignPresenter: ObservableObject {
     }
 
     func connectWalletWithWCM() {
-        Task {
-            WalletConnectModal.set(sessionParams: .init(
-                requiredNamespaces: Proposal.requiredNamespaces,
-                optionalNamespaces: Proposal.optionalNamespaces
-            ))
-        }
+        WalletConnectModal.set(sessionParams: .init(
+            requiredNamespaces: Proposal.requiredNamespaces,
+            optionalNamespaces: Proposal.optionalNamespaces
+        ))
         WalletConnectModal.present(from: nil)
     }
 

diff --git a/Sources/WalletConnectModal/Modal/Screens/WalletDetail/WalletDetailViewModel.swift b/Sources/WalletConnectModal/Modal/Screens/WalletDetail/WalletDetailViewModel.swift
@@ -35,15 +35,8 @@ final class WalletDetailViewModel: ObservableObject {
 
     func handle(_ event: Event) {
         switch event {
-        case .onAppear:
+        case .onAppear, .didTapUniversalLink, .didTapTryAgain:
             deeplinkToWallet()
-
-        case .didTapUniversalLink:
-            deeplinkToWallet()
-
-        case .didTapTryAgain:
-           deeplinkToWallet()
-
         case .didTapAppStore:
             deeplinkHandler.openAppstore(wallet: wallet)
         }

diff --git a/Sources/WalletConnectModal/Modal/Screens/WalletList.swift b/Sources/WalletConnectModal/Modal/Screens/WalletList.swift
@@ -33,11 +33,11 @@ struct WalletList: View {
             // iOS 14 doesn't have extra separators below the list by default.
         } else {
             // To remove only extra separators below the list:
-            UITableView.appearance().tableFooterView = UIView()
+            UITableView.appearance(whenContainedInInstancesOf: [WalletConnectModalSheetController.self]).tableFooterView = UIView()
         }
 
         // To remove all separators including the actual ones:
-        UITableView.appearance().separatorStyle = .none
+        UITableView.appearance(whenContainedInInstancesOf: [WalletConnectModalSheetController.self]).separatorStyle = .none
     }
 
     var body: some View {