Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[W3I] Redirects fix #1069

Merged
merged 1 commit into from
Sep 4, 2023
Merged

[W3I] Redirects fix #1069

merged 1 commit into from
Sep 4, 2023

Conversation

flypaper0
Copy link
Contributor

No description provided.

@flypaper0 flypaper0 requested a review from llbartekll August 30, 2023 14:53
@flypaper0 flypaper0 temporarily deployed to internal August 30, 2023 14:53 — with GitHub Actions Inactive
@@ -61,6 +61,10 @@ public final class Web3InboxClient {
public func register(deviceToken: Data) async throws {
try await notifyClient.register(deviceToken: deviceToken)
}

public func reload() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have it as a public method?
For sample app make sense to reload but does it during integration?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let leave it for now? I'm not 100% sure that logout issue totally fixed. This makes possible to recover state

@flypaper0 flypaper0 merged commit 49725d0 into develop Sep 4, 2023
8 checks passed
@flypaper0 flypaper0 deleted the hotfix/w3i-logout branch September 4, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants