Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notify] Use gm project id for explorer #1196

Merged
merged 3 commits into from
Oct 24, 2023
Merged

[Notify] Use gm project id for explorer #1196

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07d7b9b
Update Configuration.xcconfig
flypaper0 Oct 24, 2023
f8cee2e
gmDappProjectId explorer
flypaper0 Oct 24, 2023
221a4c0
Project id note
flypaper0 Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Configuration.xcconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
RELAY_HOST = relay.walletconnect.com

CAST_HOST = notify.walletconnect.com

EXPLORER_HOST = explorer-api.walletconnect.com

// Uncomment next line and paste your project id. Get this on: https://cloud.walletconnect.com/sign-in
// PROJECT_ID = YOUR_PROJECT_ID

Expand All @@ -18,5 +22,3 @@ RELAY_HOST = relay.walletconnect.com
// WALLETAPP_SENTRY_DSN = WALLETAPP_SENTRY_DSN

// MIXPANEL_TOKEN = MIXPANEL_TOKEN

CAST_HOST = notify.walletconnect.com
2 changes: 1 addition & 1 deletion Example/IntegrationTests/Push/NotifyTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ final class NotifyTests: XCTestCase {
keychainStorage: keychain,
environment: .sandbox)
let keyserverURL = URL(string: "https://keys.walletconnect.com")!
let client = NotifyClientFactory.create(projectId: InputConfig.projectId,
let client = NotifyClientFactory.create(explorerProjectId: InputConfig.gmDappProjectId,
keyserverURL: keyserverURL,
logger: notifyLogger,
keyValueStorage: keyValueStorage,
Expand Down
6 changes: 3 additions & 3 deletions Sources/WalletConnectNotify/Client/Wallet/NotifyClientFactory.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ public struct NotifyClientFactory {
let groupKeychainService = GroupKeychainStorage(serviceIdentifier: groupIdentifier)

return NotifyClientFactory.create(
projectId: projectId,
explorerProjectId: projectId,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what explorerProjectId means?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on prod it's just a projectID correct?

keyserverURL: keyserverURL,
logger: logger,
keyValueStorage: keyValueStorage,
Expand All @@ -26,7 +26,7 @@ public struct NotifyClientFactory {
}

static func create(
projectId: String,
explorerProjectId: String,
keyserverURL: URL,
logger: ConsoleLogging,
keyValueStorage: KeyValueStorage,
Expand All @@ -50,7 +50,7 @@ public struct NotifyClientFactory {
let deleteNotifySubscriptionRequester = DeleteNotifySubscriptionRequester(keyserver: keyserverURL, networkingInteractor: networkInteractor, identityClient: identityClient, webDidResolver: webDidResolver, kms: kms, logger: logger, notifyStorage: notifyStorage)
let resubscribeService = NotifyResubscribeService(networkInteractor: networkInteractor, notifyStorage: notifyStorage, logger: logger)

let notifyConfigProvider = NotifyConfigProvider(projectId: projectId, explorerHost: explorerHost)
let notifyConfigProvider = NotifyConfigProvider(projectId: explorerProjectId, explorerHost: explorerHost)

let notifySubscribeRequester = NotifySubscribeRequester(keyserverURL: keyserverURL, networkingInteractor: networkInteractor, identityClient: identityClient, logger: logger, kms: kms, webDidResolver: webDidResolver, notifyConfigProvider: notifyConfigProvider)

Expand Down