Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notify] Handle empty subscriptions response #1255

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

flypaper0
Copy link
Contributor

@flypaper0 flypaper0 commented Dec 13, 2023

Description

  • db replace method implemented
  • empty scope update tests

Context: https://walletconnect.slack.com/archives/C044SKFKELR/p1702421327674859

How Has This Been Tested?

Due Dilligence

  • Breaking change
  • Requires a documentation update

@flypaper0 flypaper0 force-pushed the hotfix/notify-db-replace-method branch from 46e1094 to 70af343 Compare January 8, 2024 06:54
@flypaper0 flypaper0 requested a review from llbartekll January 8, 2024 07:00
@flypaper0 flypaper0 marked this pull request as ready for review January 8, 2024 07:00
@flypaper0 flypaper0 force-pushed the hotfix/notify-db-replace-method branch from 70af343 to 47ae69c Compare January 9, 2024 12:30
@flypaper0 flypaper0 requested a review from radeknovis January 9, 2024 12:38
@flypaper0 flypaper0 merged commit 3aa214e into develop Jan 11, 2024
8 checks passed
@flypaper0 flypaper0 deleted the hotfix/notify-db-replace-method branch January 11, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants