Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wallet] add chain changed #1402

Merged
merged 3 commits into from
Aug 20, 2024
Merged

[Wallet] add chain changed #1402

merged 3 commits into from
Aug 20, 2024

Conversation

llbartekll
Copy link
Contributor

Description

Resolves # (issue)

How Has This Been Tested?

Due Dilligence

  • Breaking change
  • Requires a documentation update

Copy link

sonarcloud bot commented Aug 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@jackpooleywc jackpooleywc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ActivityIndicatorManager.shared.stop()
} catch {
ActivityIndicatorManager.shared.stop()
print(error)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably use a proper logger for cases like this

@llbartekll llbartekll merged commit a311e0a into develop Aug 20, 2024
5 of 6 checks passed
@llbartekll llbartekll deleted the add-update-to-sample-wallet branch August 20, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants