Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ERC7715 method on ethereum provider #4576

Open
wants to merge 2 commits into
base: v2.0
Choose a base branch
from
Open

Conversation

KannuSingh
Copy link
Collaborator

@KannuSingh KannuSingh commented May 30, 2024

Description

Adding ERC 7715 method (wallet_issuePermissions) (wallet_grantPermissions) on ethereum-provider optional rpc methods list and type.

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your configuration.

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Additional Information (Optional)

Please include any additional information that may be useful for the reviewer.

@KannuSingh KannuSingh marked this pull request as ready for review June 3, 2024 05:13
@lukaisailovic
Copy link
Contributor

Lets hold off on merging this until the EIP PR is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants