Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] 유저 서비스 레이어 테스트 #24

Merged
merged 2 commits into from
Nov 20, 2023
Merged

[test] 유저 서비스 레이어 테스트 #24

merged 2 commits into from
Nov 20, 2023

Conversation

9898s
Copy link
Contributor

@9898s 9898s commented Nov 8, 2023

관련 Issue

변경 사항

  • 회원가입 성공 테스트 코드가 작성됐습니다.
  • 중복 아이디로 인한 회원가입 실패 테스트 코드가 작성됐습니다.

Check List

  • 모든 테스트 코드가 통과 되나요?
스크린샷 2023-11-08 오후 8 04 35

@9898s 9898s added the test test code label Nov 8, 2023
@9898s 9898s self-assigned this Nov 8, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2023

Test Results

3 tests  +2   3 ✔️ +2   1s ⏱️ -1s
2 suites +1   0 💤 ±0 
2 files   +1   0 ❌ ±0 

Results for commit f82999c. ± Comparison against base commit 2f23cff.

JisooPyo
JisooPyo approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@JisooPyo JisooPyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

깔끔하네요! 수환님께 테스트 코드 많이 배웁니다!!

@JisooPyo JisooPyo linked an issue Nov 8, 2023 that may be closed by this pull request
[test] 유저 테스트 코드 작성 #23
Closed
rivkode
rivkode approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@rivkode rivkode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@9898s 수고하셨습니다 !

@rivkode rivkode merged commit 90a3d61 into develop Nov 20, 2023
3 checks passed
@rivkode rivkode deleted the test/23/user branch November 20, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JisooPyo JisooPyo JisooPyo approved these changes

@rivkode rivkode rivkode approved these changes

@dyori04 dyori04 Awaiting requested review from dyori04

Assignees

@9898s 9898s

Labels
test test code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[test] 유저 테스트 코드 작성
3 participants
@9898s @rivkode @JisooPyo