Skip to content

Commit

Permalink
Version pin GitHub Runners to Windows 2022 and Ubuntu 22.04 (#603)
Browse files Browse the repository at this point in the history
Version pin to Windows 2022 and Ubuntu 22.04
  • Loading branch information
Washi1337 authored Dec 15, 2024
1 parent 56a7e1e commit eb7a735
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 16 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/reusable-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ env:
jobs:
get-version:
name: Calculating Version Suffix
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
outputs:
version_suffix: ${{ steps.set-vars.outputs.version_suffix }}
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/reusable-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ env:
jobs:
publish:
name: Publish NuGet Packages from Build Output Cache
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
timeout-minutes: 10
steps:
- uses: actions/checkout@v4
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/reusable-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,7 @@ jobs:
- name: Download Build Cache
uses: ./.github/actions/test-build-cache-download
with:
#image: ${{inputs.image}}
image: 'windows-latest'
image: 'windows-2022'
architecture: ${{(inputs.architecture == 'arm64' && 'x64') || inputs.architecture}}
build_configuration: ${{inputs.build_configuration}}

Expand Down
20 changes: 10 additions & 10 deletions .github/workflows/test-and-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
# without comprimizing the security
upload-event-file:
name: Upload Event File
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- name: Upload event file
uses: actions/upload-artifact@v4
Expand All @@ -53,7 +53,7 @@ jobs:
# https://stackoverflow.com/a/77549656
variables:
name: Variable Accessibility Workaround for Jobs
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
outputs:
EXPERIMENTAL: ${{ env.EXPERIMENTAL == 'true' || (github.event == 'push' && github.ref == 'refs/heads/master' || github.ref == 'refs/heads/development') }}
BUILD_CONFIGURATIONS: ${{env.BUILD_CONFIGURATIONS}}
Expand All @@ -75,8 +75,8 @@ jobs:
strategy:
matrix:
runner: [
{ image: 'windows-latest', arch: 'x64' },
{ image: 'windows-latest', arch: 'x86' },
{ image: 'windows-2022', arch: 'x64' },
{ image: 'windows-2022', arch: 'x86' },
]
build_configuration: ${{fromJson(needs.variables.outputs.BUILD_CONFIGURATIONS)}}
uses: ./.github/workflows/reusable-build.yml
Expand All @@ -92,9 +92,9 @@ jobs:
fail-fast: false
matrix:
runner: [
{ image: 'windows-latest', arch: 'x64' },
{ image: 'windows-latest', arch: 'x86' },
{ image: 'ubuntu-latest', arch: 'x64' },
{ image: 'windows-2022', arch: 'x64' },
{ image: 'windows-2022', arch: 'x86' },
{ image: 'ubuntu-22.04', arch: 'x64' },
{ image: 'macos-13', arch: 'x64' },
{ image: 'macos-14', arch: 'arm64' },
{ image: 'macos-14', arch: 'x64' },
Expand All @@ -106,16 +106,16 @@ jobs:
architecture: ${{matrix.runner.arch}}
dotnet_target_frameworks: ${{needs.variables.outputs.DOTNET_TARGET_FRAMEWORKS}}
build_configuration: ${{matrix.build_configuration}}
#ignore non-windows tests since support is yet lacking
is_experimental: ${{matrix.runner.image != 'windows-latest' && matrix.runner.image != 'ubuntu-latest'}}
# Ignore MacOS test results since support is yet lacking
is_experimental: ${{matrix.runner.image != 'windows-2022' && matrix.runner.image != 'ubuntu-22.04'}}
skip_experimental: ${{ needs.variables.outputs.EXPERIMENTAL != 'true' }}

publish:
name: Publish NuGet Packages
needs: [variables, test]
uses: ./.github/workflows/reusable-publish.yml
with:
image: 'windows-latest'
image: 'windows-2022'
architecture: 'x64'
build_configuration: 'Release'
secrets:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test-results-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ permissions: {}
jobs:
publish-test-results:
if: github.event.workflow_run.conclusion != 'skipped' && github.event.workflow_run.conclusion != 'cancelled'
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
name: Publish Test Results

permissions:
Expand All @@ -34,4 +34,4 @@ jobs:
uses: ./.github/actions/test-results-download-publish
with:
workflow_run: ${{toJSON(github.event.workflow_run)}}
experimental: true
experimental: true

0 comments on commit eb7a735

Please sign in to comment.