-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support geosite #466
Conversation
732a5c9
to
d07a9fb
Compare
|
||
impl GeoSiteMatcher { | ||
pub fn new(country_code: String, target: String, loader: &GeoData) -> anyhow::Result<Self> { | ||
let (not, code, attr_matcher) = parse(&country_code).unwrap(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we probably shouldn't crash or print en error if the country_code is empty
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
} | ||
} | ||
|
||
// work around of SIGSEGV error on Linux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is interesting, any idea what this could be?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i installed this, will take a look and see if i can find something.
it's quite insteresting that safe rust haas segment fault
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems to be an annoying bug, but i cannot reproduce the error, so have no clue
Signed-off-by: Yuwei Ba <dev@watfaq.com>
Signed-off-by: Yuwei Ba <contact@yba.dev>
Signed-off-by: Yuwei Ba <dev@watfaq.com>
Signed-off-by: Yuwei Ba <dev@watfaq.com>
Signed-off-by: Yuwei Ba <dev@watfaq.com>
the segv is likely to be a libc bug https://sourceware.org/bugzilla/show_bug.cgi?id=10652
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
🤔 This is a ...
🔗 Related issue link
#441
💡 Background and solution
migrate clash meta's geosite rule matching logc here
📝 Changelog
support geosite(succinct)
☑️ Self-Check before Merge
todos