optimize some codes with global static variables #476
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
💡 Background and solution
Hello, everyone. I was learning the project this morning and found some code can be optimized by removing the unnecessary
RwLock<T>
andOnceLock<T>
. In the following code,RUNTIME_CONTROLLER
can be wrapped withOnceCell<T>
only because it is initialized once and accessed in single thread.What's more,
&static str
can be created withinclude_str!
for more concise coding style.Thank you! : )
☑️ Self-Check before Merge
Self-Tested with
cargo run
andcurl -x http://127.0.0.1:7890 https://httpbin.yba.dev/ip
.