-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add sha256sum and version.txt #599
Conversation
4687375
to
f6d595d
Compare
@greenhat616 If you have any alternative requirement,please tell me |
5cab280
to
6123744
Compare
we might use the If the program version are inconsistant with the Here is the mihomo alpha channel output:
It is consistent with the content of |
Doing so will crate tons of commits by bot(kinda of spam i have to say). So no.
Is the If so,that's possible to do. |
I think we do not need to commit the changes after modify the version for alpha build, because we don't release a real alpha tag in github like other well-known repos do.
Yes |
Very good thinking! But it still makes action more complex, we have to do these things in every target:
I would prefer add a environment called let version = match env!(VERSION_OVERRIDE) {
Some(v) -> v
None -> env!(CARGO_PKG_VERSION)
} Now new version (.txt) format in my mind: |
Yeah. That's enough. |
Yeah let's also change the cli version output for the nightly release to make it aligned |
Yeah. If we use the And the build envs var is a good way too. |
3d2170b
to
0999a57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It seems broken...... |
No description provided.