-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add labeled outlier dataframe output capability #16
Conversation
Co-Authored-By: Jenna Tomkinson <107513215+jenna-tomkinson@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! My comments are mainly regarding documentation and some questions that will help guide my understanding.
Also, we might consider updating the function names to make them a bit more distinct since they all have outliers in the names. But, exciting to see the different options including adding the boolean for if a cell passed or not for a given condition.
I am really wanting to try this out now!
Co-authored-by: Jenna Tomkinson <107513215+jenna-tomkinson@users.noreply.github.com>
Thanks @jenna-tomkinson for the review! I've replied to your comments and also applied the suggestion (thanks!). When you're able, could I ask for a revisit on the open comments to ensure everything's good (I'll also re-request review)? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for providing clarification on my questions! This PR LGTM and is ready to merge when you are! 🎉
Thanks @jenna-tomkinson ! I made some changes to reflect the default you mentioned and noticed a minor need to reconfigure |
Another note: Python 3.9 on Ubuntu 22.04 appeared to have issues in GitHub Actions so I cancelled this. All other tests succeeded, and all tests (including 3.9 on Ubuntu 22.04) succeeded in a prior commit. I expect these all to pass on merge to main. |
Description
This PR adds capabilities to output a full dataframe with scores and a column indicating whether threshold(s) pass for rows of the provided dataframe. Along the way I found I need to further modularize the work and increase typing / documentation throughout. I also took a chance to increase testing overall with a "basic" / simulated dataset + parquet-based output (which would otherwise be many lines of data within a Python file) to help increase our testing coverage and make changes more visible.
Thanks for any feedback you may have!
Closes #10
What kind of change(s) are included?
Checklist
Please ensure that all boxes are checked before indicating that this pull request is ready for review.