Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SCDataFrame name to CytoDataFrame #50

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Jul 11, 2024

Description

This PR updates the name of the class SCDataFrame to CytoDataFrame to help increase the alignment with other existing software in the same space and also to make the name more immediately recognizable to the single-cell domain.

A minor change to poetry-dynamic-versioning is also made to help avoid changes to the __init__.py.

Closes #49

What kind of change(s) are included?

  • Feature (adds or updates new capabilities)
  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have searched for existing content to ensure this is not a duplicate.
  • I have performed a self-review of these additions (including spelling, grammar, and related).
  • These changes pass all pre-commit checks.
  • I have added comments to my code to help provide understanding
  • I have added a test which covers the code changes found within this PR
  • I have deleted all non-relevant text in this pull request template.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@d33bs d33bs marked this pull request as ready for review July 15, 2024 14:15
@d33bs d33bs requested a review from jenna-tomkinson July 15, 2024 14:15
Copy link
Member

@jenna-tomkinson jenna-tomkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like every SCDataFrame was changed to the new name (I like it!) so I am approving this PR. Nice job and great small change!

src/cosmicqc/__init__.py Outdated Show resolved Hide resolved
@d33bs
Copy link
Member Author

d33bs commented Jul 15, 2024

Thanks @jenna-tomkinson for the review! Merging this in after making a change based on your comments.

@d33bs d33bs merged commit 6b86ccc into WayScience:main Jul 15, 2024
11 checks passed
@d33bs d33bs deleted the scdataframe-to-cytodataframe branch July 15, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename SCDataFrame to CytoDataFrame
2 participants