Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logo #53

Merged
merged 3 commits into from
Jul 19, 2024
Merged

Logo #53

merged 3 commits into from
Jul 19, 2024

Conversation

vincerubinetti
Copy link
Contributor

@vincerubinetti vincerubinetti commented Jul 17, 2024 •
edited
Loading

jenna-tomkinson
jenna-tomkinson reviewed Jul 17, 2024
View reviewed changes
Copy link
Member

@jenna-tomkinson jenna-tomkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much Vincent, this logo is amazing! I made one comment for you to look at, specifically about the logo + text files.

I think after that comment is addressed, this logo is perfect!

logo/with-text-for-dark-bg.png Show resolved Hide resolved
logo/just-icon.png Show resolved Hide resolved
jenna-tomkinson
jenna-tomkinson approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@jenna-tomkinson jenna-tomkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you again Vincent for your work on this logo! I also got to learn some stuff on logos which is cool too!

logo/with-text-for-dark-bg.png Show resolved Hide resolved
@vincerubinetti
Copy link
Contributor Author

If you're happy with it, feel free to merge. Also you'll see i've included the source code if any changes are needed in the future.

@jenna-tomkinson jenna-tomkinson merged commit c9bb29b into WayScience:main Jul 19, 2024
11 checks passed
@vincerubinetti vincerubinetti deleted the logo branch July 19, 2024 21:22
@jenna-tomkinson jenna-tomkinson mentioned this pull request Jul 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenna-tomkinson jenna-tomkinson jenna-tomkinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincerubinetti @jenna-tomkinson