Add documentation about starting file descriptors in Preview1. #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add documentation mentioning stdin, stdout, and stderr file descriptors, and also preopen file descriptors, and mention that preopen file descriptors can be closed. Allowing preopen file descriptors to be closed is a change from how Wasmtime historically worked, but I think it's more clear now that it's ok to let preopens be closed. We'll change Wasmtime accordingly. This addresses WebAssembly/wasi-testsuite#50.
yamt
reviewed
Feb 28, 2023
legacy/application-abi.md
Outdated
| @@ -51,6 +51,13 @@ Regardless of the kind, all modules accessing WASI APIs also export a table | |||
| with the name `__indirect_function_table`. Function pointers in WASI API calls | |||
| are relative to this table's index space. | |||
|
|
|||
| When `_start` or `_initialize` is called, environments shall provide file | |||
| descriptors with indices 0, 1, and 2 representing file-like resources for | |||
There was a problem hiding this comment.
what do you mean by "file-like"?
the wording made me think regular files. but i guess it isn't what you meant here.
There was a problem hiding this comment.
That's a good point, "file-like" is ambiguous. I've now changed it to say "stream" instead.
yamt
approved these changes
Mar 3, 2023
sunfishcode
added a commit
to sunfishcode/wasi-testsuite
that referenced
this pull request
Mar 20, 2023
This updates the close_preopens test to the latest upstream version, which implements WebAssembly/WASI#522. Preopens may now be closed.
loganek
pushed a commit
to WebAssembly/wasi-testsuite
that referenced
this pull request
Mar 21, 2023
This updates the close_preopens test to the latest upstream version, which implements WebAssembly/WASI#522. Preopens may now be closed.
yamt
added a commit
to yamt/toywasm
that referenced
this pull request
Apr 17, 2023
yamt
added a commit
to yamt/toywasm
that referenced
this pull request
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add documentation mentioning stdin, stdout, and stderr file descriptors, and also preopen file descriptors, and mention that preopen file descriptors can be closed.
Allowing preopen file descriptors to be closed is a change from how Wasmtime historically worked, but I think it's more clear now that it's ok to let preopens be closed. We'll change Wasmtime accordingly.
This addresses WebAssembly/wasi-testsuite#50.