Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shareability of externalized nulls #6791

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

kripken
Copy link
Member

@kripken kripken commented Jul 30, 2024

No description provided.

@kripken kripken requested a review from tlively July 30, 2024 15:56
Copy link
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! How many iterations is your fuzzing going through before finding a bug on average?

@kripken
Copy link
Member Author

kripken commented Jul 30, 2024

O(100K) I'd say, after these last fixes.

@kripken kripken merged commit e6bbff7 into WebAssembly:main Jul 30, 2024
13 checks passed
@kripken kripken deleted the extern.convert_any branch July 30, 2024 21:29
@tlively
Copy link
Member

tlively commented Jul 30, 2024

Sounds good. I probably should have left it running longer (O(1M)?) locally before landing the fuzzer support upstream. Sorry for all the busy work!

@kripken
Copy link
Member Author

kripken commented Jul 30, 2024

No worries. Sometimes it's hard to predict the fallout.

I've never waited 1M for anything... overnight at the most, which is around 100K.

@gkdn gkdn mentioned this pull request Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants