Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention a few more possible implementation limits #293

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

yamt
Copy link
Contributor

@yamt yamt commented Jan 29, 2024

@@ -46,6 +46,8 @@ An implementation may impose restrictions on the following dimensions of a modul
* the number of results in a :ref:`function type <syntax-functype>`
* the number of parameters in a :ref:`block type <syntax-blocktype>`
* the number of results in a :ref:`block type <syntax-blocktype>`
* the number of parameters in a :ref:`tag type <syntax-tagtype>`
* the total size of parameters in a :ref:`tag type <syntax-tagtype>`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "size" of parameters is not a well-defined notion for the spec, since e.g. reference types have no observable size. However, we can omit this item, since it is already subsumed by the number of parameters (for which the limit may vary with their types) – the same is already assumed for function parameters, locals, etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. i removed the item.

* the size of some types are not well defined

* it's considered subsumed by the "number of parameters" item above
Copy link
Member

@rossberg rossberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rossberg rossberg merged commit cecb8d6 into WebAssembly:main Jan 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants