-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Producers Section to match #93 #100
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the deleted content I think is still useful at capturing intent for toolchains who do find this section useful. In particular, size-optimizing toolchains (like Emscripten) are likely to strip the section, but less size-conscious toolchains should still feel encouraged to support it.
I personally feel like the phrasing of "size-optimizing toolchains" isn't quite right here because the Rust toolchain, for example, is (as always) size optimizing yet we intend to continue to emit the producers section by default. There are other examples of "useless in production" sections being emitted by default by toolchains such as the It seems like it'd be unfortunate to get into a situation where everyone's code-golfing how small their wasm can be to the point where very useful information is being stripped for a proportionally larger loss of functionality. |
I feel like the size comment had value. I think it depends on which level of the tools we focus on. That is, I can see how Rust may not want to make any decision at all about the producers section, and just leave it to later tools. For a complete toolchain though, like say emcc, which does not assume any tool will run after it, it does make sense to strip the producers section by default for size (and information leakage) reasons. |
Happy to let someone else take over this PR and put the wording just right from a producer's perspective. |
As discussed in #93/comment and the recent CG meeting.