delete preopens interface from package, replace with wasi:filesystem/preopens
#19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 3, 2023 14:53
wasi:filesystem/preopens is where the get-directories part of preopens has moved to. the initial-cwd function in preopens needed a new home, so I put it in environment, because it seems morally similar enough.
sunfishcode
approved these changes
Aug 3, 2023
pchickey
pushed a commit
to bytecodealliance/wasmtime
that referenced
this pull request
Aug 4, 2023
…si-cli wasi-cli import is sum of WebAssembly/wasi-cli#19 and WebAssembly/wasi-cli#20
pchickey
pushed a commit
to bytecodealliance/wasmtime
that referenced
this pull request
Aug 8, 2023
…si-cli wasi-cli import is sum of WebAssembly/wasi-cli#19 and WebAssembly/wasi-cli#20
elliottt
pushed a commit
to bytecodealliance/wasmtime
that referenced
this pull request
Aug 15, 2023
…si-cli wasi-cli import is sum of WebAssembly/wasi-cli#19 and WebAssembly/wasi-cli#20
github-merge-queue bot
pushed a commit
to bytecodealliance/wasmtime
that referenced
this pull request
Aug 15, 2023
* rename wasi-cli-base to wasi-cli, delete `preview` package, import wasi-cli wasi-cli import is sum of WebAssembly/wasi-cli#19 and WebAssembly/wasi-cli#20 * wasi impl: change bindgen arguments and mod paths from cli_base to cli * correct name of wasi-cli deps dir to just `deps/cli/` it turns out this isnt semantically meaningful, since the package name is in the document itself now, but lets be consistient * track whether stdio isatty in ctx, and impl the cli/terminal-* interfaces * rebase fixup * wasi wits: define the reactor adapter's world * component adapter: fixes * test-programs/command-tests: fix renaming cli_base to cli * component adapter: fix manually-defined export and import names * test harness fixes * preview1 component adapter: fill in isatty detection * implement isatty in preview2-to-preview1 host adapter * test-programs: cover both when stdio isatty and not prtest:full * split isatty test for regular file and stdio, detect host stdio is_terminal CI environments vary - let the test runner make sure the host process's stdio is in fact a terminal before asserting that the guest sees it is a terminal. * provide an is-terminal impl for all preview2's stdio types which means making a newtype around Stdout and Stderr instead of using a type alias there. and then use the is-terminal impl to fill in the isatty field in the builder when inheriting. if you need to override it you can always builder.stdin(stdio::stdin(), your_own_idea_of_isatty) * finally, rename IsATTY variants to Yes and No * Fix the reference to IsATTY::No * more forgotten renamings --------- Co-authored-by: Trevor Elliott <telliott@fastly.com>
eduardomourar
pushed a commit
to eduardomourar/wasmtime
that referenced
this pull request
Aug 18, 2023
…e#6806) * rename wasi-cli-base to wasi-cli, delete `preview` package, import wasi-cli wasi-cli import is sum of WebAssembly/wasi-cli#19 and WebAssembly/wasi-cli#20 * wasi impl: change bindgen arguments and mod paths from cli_base to cli * correct name of wasi-cli deps dir to just `deps/cli/` it turns out this isnt semantically meaningful, since the package name is in the document itself now, but lets be consistient * track whether stdio isatty in ctx, and impl the cli/terminal-* interfaces * rebase fixup * wasi wits: define the reactor adapter's world * component adapter: fixes * test-programs/command-tests: fix renaming cli_base to cli * component adapter: fix manually-defined export and import names * test harness fixes * preview1 component adapter: fill in isatty detection * implement isatty in preview2-to-preview1 host adapter * test-programs: cover both when stdio isatty and not prtest:full * split isatty test for regular file and stdio, detect host stdio is_terminal CI environments vary - let the test runner make sure the host process's stdio is in fact a terminal before asserting that the guest sees it is a terminal. * provide an is-terminal impl for all preview2's stdio types which means making a newtype around Stdout and Stderr instead of using a type alias there. and then use the is-terminal impl to fill in the isatty field in the builder when inheriting. if you need to override it you can always builder.stdin(stdio::stdin(), your_own_idea_of_isatty) * finally, rename IsATTY variants to Yes and No * Fix the reference to IsATTY::No * more forgotten renamings --------- Co-authored-by: Trevor Elliott <telliott@fastly.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, update all wit deps to their latest editions.
preopens.get-directorieshas a new home inwasi:filesystem/preopens.preopens.initial-cwdneeded a new home, so I put it inenvironment.