feat!: Rename reactor to imports #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have established a convention for WASI proposals to have a world definition called `imports`. This change updates the `command` world to include an `imports` world rather than `reactor`. The goal is to establish consistency with this change as well as clear up some confusion around command vs reactors in this context. Additionally, this change takes advantage of the `include` syntax to include the `imports` worlds across WASI proposals.
|
Sounds good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have established a convention for WASI proposals
to have a world definition called
imports.This change updates the
commandworld to includean
importsworld rather thanreactor. The goalis to establish consistency with this change as
well as clear up some confusion around command
vs reactors in this context.
Additionally, this change takes advantage of the
includesyntax to include the
importsworlds across WASIproposals.