Fix recursive mutex #433
Merged
Fix recursive mutex #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the robust mutex logic in musl seems to assume that the bit 29 of TIDs is always zero for some reasons. from https://git.musl-libc.org/cgit/musl/commit/?id=099b89d3840c30d7dd962e18668c2e6d39f0c626 > note that the kernel ABI also reserves bit 29 > not to appear in any tid, i'm not sure if the assumption is true or not, given that FUTEX_TID_MASK is 0x3fffffff. anyway, when using non-default type of mutex like recursive mutex, it causes problems as we actually use TID 0x3fffffff for the main thread. as we don't support robust mutex anyway, this commit simply comments out the problematic condition. fixes: bytecodealliance/wasm-micro-runtime#2466
|
actually it affects any non-normal mutex, not only recursive one, if I got it right. I think we should aim to merge it as soon as we can |
yamt
added a commit
to yamt/wasi-sdk
that referenced
this pull request
Aug 29, 2023
To include: WebAssembly/wasi-libc#433
abrown
pushed a commit
to WebAssembly/wasi-sdk
that referenced
this pull request
Aug 30, 2023
To include: WebAssembly/wasi-libc#433
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the robust mutex logic in musl seems to assume that the bit 29 of TIDs is always zero for some reasons.
from https://git.musl-libc.org/cgit/musl/commit/?id=099b89d3840c30d7dd962e18668c2e6d39f0c626
i'm not sure if the assumption is true or not, given that FUTEX_TID_MASK is 0x3fffffff.
anyway, when using non-default type of mutex like recursive mutex, it causes problems as we actually use TID 0x3fffffff for the main thread.
as we don't support robust mutex anyway, this commit simply comments out the problematic condition.
fixes: bytecodealliance/wasm-micro-runtime#2466