include pthread.h for all targets #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per WebAssembly#501, this restores the pre-WASI-SDK-22 behavior of including a copy of pthread.h for all targets -- not just the `*-threads` targets. This helps minimize the number of preprocessor guards required to port existing POSIX software to WASI. It also make it easier for projects using WASI-SDK versions earlier than 22 to upgrade. Note that this includes the pthread.h header, but no stub function definitions to link against. We should probably provide the latter as well, but I'll leave that for a separate PR. Signed-off-by: Joel Dice <joel.dice@fermyon.com>
sbc100
approved these changes
May 28, 2024
sunfishcode
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #501, this restores the pre-WASI-SDK-22 behavior of including a copy of pthread.h for all targets -- not just the
*-threadstargets. This helps minimize the number of preprocessor guards required to port existing POSIX software to WASI. It also make it easier for projects using WASI-SDK versions earlier than 22 to upgrade.Note that this includes the pthread.h header, but no stub function definitions to link against. We should probably provide the latter as well, but I'll leave that for a separate PR.