Some followups and polish for the tutorial #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithamus
reviewed
Jan 11, 2023
Comment on lines
+9
to
+10
| In this tutorial, we will walk through the process of creating a Web Component that can be used to display Mastodon | ||
| posts on any website or application. |
There was a problem hiding this comment.
I wonder what this paragraph really adds? Perhaps we can just remove it?
|
|
||
| To make sure that the URL isn't malformed, we pass it through the URL constructor before returning the attribute value. | ||
| To make sure that the URL is valid, we pass it through the URL constructor before returning the attribute value. |
There was a problem hiding this comment.
Suggested change
| To make sure that the URL is valid, we pass it through the URL constructor before returning the attribute value. | |
| To always have a valid URL, pass it through the URL constructor before returning the attribute value. |
| And we can persist the value to an attribute using `setAttribute`: | ||
| ## Fetching the data | ||
|
|
||
| Now we can use the fetch method to make a network request and display the data that we receive. |
There was a problem hiding this comment.
Suggested change
| Now we can use the fetch method to make a network request and display the data that we receive. | |
| The fetch method to make a network request and display the data from the response. |
Comment on lines
+75
to
+80
| {% tip %} | ||
|
|
||
| To support all modern browser make sure to provide a fallback approach for those browser which does not support the | ||
| `CSSStyleSheet` API. | ||
|
|
||
| {% endtip %} |
There was a problem hiding this comment.
Something for us to do here is have a reference section on polyfills, which we can link to for items like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are just some random changes I've done.