Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependency stylelint to v15 [SECURITY] - autoclosed #93

Closed
wants to merge 1 commit into from
Closed

Update dependency stylelint to v15 [SECURITY] - autoclosed #93

wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 7, 2023 •
edited
Loading

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
stylelint (source) ^14.16.1 -> ^15.0.0 age adoption passing confidence

GitHub Vulnerability Alerts

GHSA-f7xj-rg7h-mc87

Summary

Our meow dependency (which we use for our CLI) depended on semver@5.7.1 . A vulnerability in this version of semver was recently identified and surfaced by npm audit:

Regular Expression Denial of Service - GHSA-c2qf-rxjj-qqgw

Details

Original post by the reporter:

"my npm audit show the report

semver <7.5.2
Severity: moderate
semver vulnerable to Regular Expression Denial of Service - GHSA-c2qf-rxjj-qqgw
No fix available

And my dependencies tree for semver show your package

├─┬ stylelint@15.9.0
│ └─┬ meow@9.0.0
│ └─┬ read-pkg-up@7.0.1
│ └─┬ read-pkg@5.2.0
│ └─┬ normalize-package-data@2.5.0
│ └── semver@5.7.1 deduped

I found that meow@10.x.x contains normalize-package-data@5 and I can fix this vulnerability because it uses semver@7. But I can't update meow to the new major version because your package doesn't allow it."

Update your package to use the 'meow' version >=10"

PoC

N/A

Impact

We anticipate the impact to be low as Stylelint is a dev tool and meow is only used on the CLI pathway.

⬇️ EDITED AFTER PUBLISHED ⬇️

Security fix backported to older semver versions

The same security fix has been backported to older semver versions of 5.x and 6.x. See the CVE-2022-25883 details.

So, you can fix this vulnerability by just updating semver in your project's dependency tree, instead of updating stylelint. For details, see the example:

package.json:

{
  "dependencies": {
    "stylelint": "15.10.0"
  }
}

Run npm audit (here is no alert for semver):

$ npm ci
...

$ npm audit
...
stylelint  8.0.0 - 15.10.0
Stylelint has vulnerability in semver dependency - https://github.com/advisories/GHSA-f7xj-rg7h-mc87
fix available via `npm audit fix --force`
Will install stylelint@15.10.1, which is outside the stated dependency range
node_modules/stylelint

1 low severity vulnerability
...

$ npm ls semver
...
└─┬ stylelint@15.10.0
  └─┬ meow@9.0.0
    ├─┬ normalize-package-data@3.0.3
    │ └── semver@7.5.4
    └─┬ read-pkg-up@7.0.1
      └─┬ read-pkg@5.2.0
        └─┬ normalize-package-data@2.5.0
          └── semver@5.7.2

Release Notes

stylelint/stylelint (stylelint)

v15.10.1

Compare Source

v15.10.0

Compare Source

v15.9.0

Compare Source

  • Added: insideFunctions: {"function": int} to number-max-precision (#​6932) (@​romainmenke).
  • Fixed: declaration-block-no-redundant-longhand-properties autofix for border-radius shorthand (#​6958) (@​mattxwang).
  • Fixed: declaration-block-no-redundant-longhand-properties autofix for border-width shorthand (#​6956) (@​mattxwang).
  • Fixed: declaration-block-no-redundant-longhand-properties autofix for grid-column and grid-row (#​6957) (@​mattxwang).

v15.8.0

Compare Source

v15.7.0

Compare Source

v15.6.3

Compare Source

v15.6.2

Compare Source

v15.6.1

Compare Source

v15.6.0

Compare Source

  • Added: allowEmptyInput, cache, fix options to configuration object (#​6778) (@​mattxwang).
  • Added: ignore: ["with-var-inside"] to color-function-notation (#​6802) (@​mattxwang).
  • Fixed: declaration-block-no-duplicate-properties autofix for 3 or more duplicates (#​6801) (@​mattxwang).
  • Fixed: declaration-block-no-duplicate-properties false positives with option ignore: ["consecutive-duplicates-with-different-syntaxes"] (#​6797) (@​romainmenke).
  • Fixed: declaration-block-no-duplicate-properties syntax error (#​6792) (@​yoyo837).
  • Fixed: declaration-block-no-redundant-longhand-properties autofix for grid-template (#​6777) (@​mattxwang).
  • Fixed: function-url-quotes autofix for comments in SCSS function (#​6800) (@​ybiquitous).

v15.5.0

Compare Source

v15.4.0

Compare Source

v15.3.0

Compare Source

v15.2.0

Compare Source

v15.1.0

Compare Source

v15.0.0

Compare Source

Migrating to 15.0.0 guide.

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate
Copy link
Contributor Author

renovate bot commented Jul 7, 2023

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: package-lock.json
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: stylelint-config-standard@29.0.0
npm ERR! Found: stylelint@15.10.1
npm ERR! node_modules/stylelint
npm ERR!   dev stylelint@"^15.0.0" from the root project
npm ERR!   peer stylelint@">= 11 < 16" from stylelint-use-logical@2.1.0
npm ERR!   node_modules/stylelint-use-logical
npm ERR!     dev stylelint-use-logical@"^2.0.0" from the root project
npm ERR!   1 more (stylelint-use-nesting)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer stylelint@"^14.14.0" from stylelint-config-standard@29.0.0
npm ERR! node_modules/stylelint-config-standard
npm ERR!   dev stylelint-config-standard@"^29.0.0" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: stylelint@14.16.1
npm ERR! node_modules/stylelint
npm ERR!   peer stylelint@"^14.14.0" from stylelint-config-standard@29.0.0
npm ERR!   node_modules/stylelint-config-standard
npm ERR!     dev stylelint-config-standard@"^29.0.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! 
npm ERR! For a full report see:
npm ERR! /tmp/worker/ddae6e/d4bd81/cache/others/npm/_logs/2023-07-07T23_11_27_039Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /tmp/worker/ddae6e/d4bd81/cache/others/npm/_logs/2023-07-07T23_11_27_039Z-debug-0.log

@renovate renovate bot changed the title Update dependency stylelint to v15 [SECURITY] Update dependency stylelint to v15 [SECURITY] - autoclosed Jul 13, 2023
@renovate renovate bot closed this Jul 13, 2023
@renovate renovate bot deleted the renovate/npm-stylelint-vulnerability branch July 13, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0 participants