Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable users to migrate tsdb cache data home #53

Merged
merged 6 commits into from
Dec 20, 2023
Merged

Enable users to migrate tsdb cache data home #53

merged 6 commits into from
Dec 20, 2023

Conversation

WenjieDu
Copy link
Owner

What does this PR do?

  1. fixing Enable users to customize the directory path of cached datasets #51;

Before submitting

  • This PR is made to fix a typo or improve the docs (you can dismiss the other checks if this is the case).
  • Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have written necessary tests and already run them locally.

Copy link

github-actions bot commented Dec 20, 2023

Pull Request Test Coverage Report for Build 7277325708

  • 14 of 39 (35.9%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+13.6%) to 76.744%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tsdb/database.py 8 10 80.0%
tsdb/utils/file.py 3 26 11.54%
Totals Coverage Status
Change from base Build 7271584081: 13.6%
Covered Lines: 396
Relevant Lines: 516

💛 - Coveralls

1 similar comment
Copy link

Pull Request Test Coverage Report for Build 7277325708

  • 14 of 39 (35.9%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+13.6%) to 76.744%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tsdb/database.py 8 10 80.0%
tsdb/utils/file.py 3 26 11.54%
Totals Coverage Status
Change from base Build 7271584081: 13.6%
Covered Lines: 396
Relevant Lines: 516

💛 - Coveralls

@coveralls
Copy link

coveralls commented Dec 20, 2023

Pull Request Test Coverage Report for Build 7277590013

  • 26 of 42 (61.9%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+15.5%) to 78.613%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tsdb/database.py 8 10 80.0%
tsdb/utils/file.py 15 29 51.72%
Totals Coverage Status
Change from base Build 7271584081: 15.5%
Covered Lines: 408
Relevant Lines: 519

💛 - Coveralls

@WenjieDu WenjieDu merged commit 210febf into main Dec 20, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants