git: Various style fixes everywhere, removing whitespaces (#321)

* repo-wide: trim trailing spaces

Note: This doesn't touch the .tbl files in encodings/ since they include
meaningful trailing spaces (`20= `)

* patterns: clean up duplicate semicolons

* ELF: add header magic check

* glTF: use type::Magic for magic value

* glTF: check that the file size in the header matches

* xgstexture: fix generics syntax for magic value

* JPEG: define hex enum with 0x00 instead of 0X00

* CI: update deprecated actions

---------

Co-authored-by: Nik <werwolv98@gmail.com>

.github/PULL_REQUEST_TEMPLATE/pattern_template.md

@@ -9,4 +9,4 @@
 - [ ] The pattern was associated with all relevant MIME types (using `#pragma MIME mime-type` in the source code)
   - Make sure to never use `application/octet-stream` here as that means "Unidentifiable binary data"
 - [ ] A test file for this pattern has been added to [/tests/patterns/test_data](/tests/patterns/test_data)
-  - Try to keep this file below ~ 1 MB 
+  - Try to keep this file below ~ 1 MB

.github/workflows/dispatch.yml

@@ -8,7 +8,7 @@ on:
   repository_dispatch:
     types: [run_tests]
   workflow_dispatch:
-    inputs: 
+    inputs:
       generate_docs:
         description: "Regenerate docs"
         required: false
@@ -27,13 +27,13 @@ jobs:
 
     steps:
     - name: 🧰 Checkout
-      uses: actions/checkout@v2
+      uses: actions/checkout@v4
       with:
         submodules: recursive
 
     - name: 📄 Check changed include files
       id: changed-includes
-      uses: tj-actions/changed-files@v35
+      uses: tj-actions/changed-files@v45
       with:
         files: includes/**/*.pat
 
@@ -45,7 +45,7 @@ jobs:
         repo: Documentation
         owner: WerWolv
         event_type: update_pl_docs
-        
+
     - name: ✉️ Update PatternLanguage Website
       if: ${{ env.DISPATCH_TOKEN != '' }}
       uses: mvasigh/dispatch-action@main

.github/workflows/tests.yml

@@ -19,7 +19,7 @@ jobs:
 
     steps:
     - name: 🧰 Checkout
-      uses: actions/checkout@v2
+      uses: actions/checkout@v4
       with:
         submodules: recursive
 
@@ -39,7 +39,7 @@ jobs:
             python3-pip           \
             libmagic-dev          \
             lcov
-        
+
         sudo pip install jsonschema
 
     - name: 📜 Setup ccache
@@ -74,7 +74,7 @@ jobs:
         cd constants
         for file in ./[!_schema.json]*; do jsonschema -i $file _schema.json; done
         cd ..
-        
+
         cd tips
         for file in ./[!_schema.json]*; do jsonschema -i $file _schema.json; done
         cd ..

CONTRIBUTING.md

@@ -8,5 +8,5 @@ Thanks a lot for any additions or improvements :)
 ## Adding new Patterns
 
 When adding new patterns, if possible, please also add a test file named `<pattern_name>.hexpat.<extension>` to the `/tests/patterns/test_data` directory. This allows our Unit Tests to be run against your code so we can make sure it stays up-to-date and doesn't break when changes are made to the PatternLanguage.
-Please try to keep these files as small as possible (~100kiB at most) so cloning stays fast. 
+Please try to keep these files as small as possible (~100kiB at most) so cloning stays fast.
 Please also make sure to not submit any test files that are under copyright such as game files, ROMs or files extracted from other programs. We don't want a DMCA takedown on this repo.

constants/linux_errors.json

@@ -775,6 +775,6 @@
             "name": "ENOTRECOVERABLE",
             "desc": "State not recoverable"
         }
-        
+
     ]
 }

includes/hex/provider.pat

@@ -7,11 +7,11 @@ import hex.impl.imhex_check;
 */
 
 namespace auto hex::prv {
-    
-    
+
+
     /**
         Queries information from the currently loaded provider. The kind of information that's available depends on the provider that's loaded
-        
+
         > **Available information**
         > - File Provider
         >   - `file_path() -> str`
@@ -32,12 +32,12 @@ namespace auto hex::prv {
         >   - `region_size(regionName) -> u64`
         >   - `process_id() -> u32`
         >   - `process_name() -> str`
-        
+
         @param category Information category
         @param argument Extra argument to pass along
     */
     fn get_information(str category, str argument = "") {
         return builtin::hex::prv::get_information(category, argument);
     };
-    
+
 }

includes/std/bit.pat

@@ -21,7 +21,7 @@ namespace auto std::bit {
         x = (x & a) + ((x >> 1) & a);
         x = (x & b) + ((x >> 2) & b);
         x = (x & c) + ((x >> 4) & c);
-        
+
         return x % 0xFF;
     };
 
@@ -33,19 +33,19 @@ namespace auto std::bit {
     fn has_single_bit(u128 x) {
         return x != 0 && (x & (x - 1)) == 0;
     };
-    
+
     /**
         Rounds the given number up to the next bigger power of two
         @param x The number
         @return Next bigger power of two that can fit `x`
     */
-    fn bit_ceil(u128 x) {        
+    fn bit_ceil(u128 x) {
         if (x == 0) return 0;
-        
+
         u8 i;
         while ((1 << i) < x)
             i = i + 1;
-        
+
         return 1 << i;
     };
 
@@ -56,11 +56,11 @@ namespace auto std::bit {
     */
     fn bit_floor(u128 x) {
         if (x == 0) return 0;
-        
+
         u8 i;
         while ((x >> i) > 0)
             i = i + 1;
-        
+
         return 1 << (i - 1);
     };
 

includes/std/file.pat

@@ -1,7 +1,7 @@
 #pragma once
 
 /*!
-    The File library allows reading and writing from/to external files using 
+    The File library allows reading and writing from/to external files using
     a C-like File IO API.
 
     **These functions are considered dangerous and require the user to manually permit them**
@@ -13,7 +13,7 @@ namespace auto std::file {
         A handle representing a file that has been opened
     */
     using Handle = s32;
-    
+
     /**
         The mode to open a file in.
         Read opens the file in read-only mode
@@ -45,7 +45,7 @@ namespace auto std::file {
         builtin::std::file::close(handle);
     };
 
-    
+
     /**
         Reads the content of a file into a string
         @param handle The file handle to read from
@@ -85,14 +85,14 @@ namespace auto std::file {
     };
 
     /**
-        Resizes a file 
+        Resizes a file
         @param handle The handle of the file to resize
     */
     fn resize(Handle handle, u64 size) {
         builtin::std::file::resize(handle, size);
     };
 
-    /** 
+    /**
         Flushes changes made to a file to disk
         @param handle The handle of the file to flush
     */

includes/std/fxpt.pat

@@ -20,7 +20,7 @@ namespace auto std::fxpt {
     fn to_float(fixed fxt, u32 precision) {
         return double(fxt) / double((1 << precision));
     };
-    
+
     /**
         Converts a floating point value into a fixed point value
         @param flt The floating point value to convert
@@ -41,7 +41,7 @@ namespace auto std::fxpt {
     fn change_precision(fixed value, u32 start_precision, u32 end_precision) {
         return std::fxpt::to_fixed(std::fxpt::to_float(value, start_precision), end_precision);
     };
-    
+
     /**
         Adds two fixed point numbers with a given precision together
         @param a First fixed point number
@@ -52,7 +52,7 @@ namespace auto std::fxpt {
     fn add(fixed a, fixed b, u32 precision) {
         return a + b;
     };
-    
+
     /**
         Subtracts two fixed point numbers with a given precision together
         @param a First fixed point number
@@ -63,7 +63,7 @@ namespace auto std::fxpt {
     fn subtract(fixed a, fixed b, u32 precision) {
         return a - b;
     };
-    
+
     /**
         Multiplies two fixed point numbers with a given precision together
         @param a First fixed point number
@@ -74,7 +74,7 @@ namespace auto std::fxpt {
     fn multiply(fixed a, fixed b, u32 precision) {
         return (a * b) / (1 << precision);
     };
-    
+
     /**
         Divides two fixed point numbers with a given precision together
         @param a First fixed point number

includes/std/hash.pat

@@ -14,7 +14,7 @@ namespace auto std::hash {
         @param xorout The CRC8 XOR-Out value
         @param reflect_in Whether or not the input bytes should be reflected
         @param reflect_out Whether or not the output should be reflected
-        @return Calculated CRC8 hash 
+        @return Calculated CRC8 hash
     */
     fn crc8(ref auto pattern, u8 init, u8 poly, u8 xorout, bool reflect_in, bool reflect_out) {
         return builtin::std::hash::crc8(pattern, init, poly, xorout, reflect_in, reflect_out);
@@ -28,7 +28,7 @@ namespace auto std::hash {
         @param xorout The CRC16 XOR-Out value
         @param reflect_in Whether or not the input bytes should be reflected
         @param reflect_out Whether or not the output should be reflected
-        @return Calculated CRC16 hash 
+        @return Calculated CRC16 hash
     */
     fn crc16(ref auto pattern, u16 init, u16 poly, u16 xorout, bool reflect_in, bool reflect_out) {
         return builtin::std::hash::crc16(pattern, init, poly, xorout, reflect_in, reflect_out);
@@ -42,7 +42,7 @@ namespace auto std::hash {
         @param xorout The CRC32 XOR-Out value
         @param reflect_in Whether or not the input bytes should be reflected
         @param reflect_out Whether or not the output should be reflected
-        @return Calculated CRC32 hash 
+        @return Calculated CRC32 hash
     */
     fn crc32(ref auto pattern, u32 init, u32 poly, u32 xorout, bool reflect_in, bool reflect_out) {
         return builtin::std::hash::crc32(pattern, init, poly, xorout, reflect_in, reflect_out);
@@ -56,7 +56,7 @@ namespace auto std::hash {
         @param xorout The CRC64 XOR-Out value
         @param reflect_in Whether or not the input bytes should be reflected
         @param reflect_out Whether or not the output should be reflected
-        @return Calculated CRC64 hash 
+        @return Calculated CRC64 hash
     */
     fn crc64(ref auto pattern, u64 init, u64 poly, u64 xorout, bool reflect_in, bool reflect_out) {
         return builtin::std::hash::crc64(pattern, init, poly, xorout, reflect_in, reflect_out);