Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patterns/vhdx: Various improvements #154

Merged
merged 1 commit into from
Sep 10, 2023
Merged

patterns/vhdx: Various improvements #154

merged 1 commit into from
Sep 10, 2023

Conversation

nitoyon
Copy link
Contributor

@nitoyon nitoyon commented Aug 27, 2023

  • Replaced right_to_left to bitfield_order
  • Fixed type of ParentLocatorEntry (char -> char16)
  • Fixed item address of MetadataTableEntry
  • Improved RegionTableEntry

@iTrooz
Copy link
Collaborator

iTrooz commented Aug 28, 2023

Hey, you need to resolve conflicts (there were just 2 lines added at the top of the file)

@nitoyon
patterns/vhdx: Various improvements
e859d03 
* Replaced right_to_left to bitfield_order

* Fixed type of ParentLocatorEntry (char -> char16)

* Fixed item address of MetadataTableEntry

* Improved RegionTableEntry# Please enter the commit message for your changes. Lines starting
@nitoyon
Copy link
Contributor Author

nitoyon commented Aug 29, 2023

@iTrooz I have resolved the conflicts as suggested. Thank you for your guidance.

@WerWolv
Copy link
Owner

WerWolv commented Sep 10, 2023

Thanks a lot!

@WerWolv WerWolv merged commit 81f4978 into WerWolv:master Sep 10, 2023
2 checks passed
@nitoyon nitoyon deleted the vhdx branch September 11, 2023 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nitoyon @iTrooz @WerWolv