Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patterns/GBA Header #323

Merged
merged 5 commits into from
Nov 28, 2024
Merged

Patterns/GBA Header #323

merged 5 commits into from
Nov 28, 2024

Conversation

GekySan
Copy link
Contributor

@GekySan GekySan commented Nov 24, 2024

Hello, this PR adds:

  • Game Boy Advance (GBA) hexpat.

No test files could be included due to copyright.

Added support for cartridge size type $54, corresponding to 1.5 MiB (96 banks).
Added GBA information to README.md and corrected a typo.
@Lemon4ksan
Copy link
Contributor

There's a typo in line 139 'return Unknown Licensee";

@GekySan
Copy link
Contributor Author

GekySan commented Nov 24, 2024

There's a typo in line 139 'return Unknown Licensee";

Hello, I don’t see any typo errors. Could you clarify where it is, please ?

@paxcut
Copy link
Contributor

paxcut commented Nov 24, 2024

I am pretty sure Lemon4san means Licensee which in this case is not a typo, but what else could it be, return? unknown? I don't think so.

Among other meaning, a licensee is a person or group who is in possession of a license.

@GekySan
Copy link
Contributor Author

GekySan commented Nov 24, 2024

I am pretty sure Lemon4san means Licensee which in this case is not a typo, but what else could it be, return? unknown? I don't think so.

Among other meaning, a licensee is a person or group who is in possession of a license.

Ah, but I think Licensee is correct, and anyway, as mentioned in the comment in the code, I copied what WerWolv did in Game Boy.

@paxcut
Copy link
Contributor

paxcut commented Nov 24, 2024

I wasn't clear enough and for that I am sorry. My comment was meant to indicate that the above mentioned post incorrectly classified Licensee as a typo. That's an understandable mistake if English is not your mother tongue.

I added the definition for the benefit of those who doubt it is the correct spelling.

@Lemon4ksan
Copy link
Contributor

Sorry, my bad

@WerWolv WerWolv merged commit 500a3fe into WerWolv:master Nov 28, 2024
2 checks passed
@WerWolv
Copy link
Owner

WerWolv commented Nov 28, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants