Prevent logging network errors

WesselKroos · Sep 16, 2024 · 4d7c26d · 4d7c26d
1 parent 40819ef
commit 4d7c26d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 16 deletions.
diff --git a/src/scripts/libs/ambientlight.js b/src/scripts/libs/ambientlight.js
@@ -525,7 +525,10 @@ export default class Ambientlight {
       if (this.chromiumBugVideoJitterWorkaround?.update)
         this.chromiumBugVideoJitterWorkaround.update();
     } catch (ex) {
-      if (!isNetworkError(ex)) {
+      if (
+        !['InvalidStateError', 'SecurityError'].includes(ex?.name) &&
+        !isNetworkError(ex)
+      ) {
         SentryReporter.captureException(ex);
       }
     }

diff --git a/src/scripts/libs/generic.js b/src/scripts/libs/generic.js
@@ -511,8 +511,8 @@ export const setWarning = (text) => {
 };
 
 export const isNetworkError = (ex) =>
-  ex?.message !== 'Failed to fetch' && // Chromium
-  ex?.message !== 'NetworkError when attempting to fetch resource.'; // Firefox
+  ex?.message === 'Failed to fetch' || // Chromium
+  ex?.message === 'NetworkError when attempting to fetch resource.'; // Firefox
 
 export const setStyleProperty = (elem, name, value, priority = '') => {
   const currentValue = elem.style.getPropertyValue(name) ?? '';

diff --git a/src/scripts/libs/static-image-detection.js b/src/scripts/libs/static-image-detection.js
@@ -1,4 +1,4 @@
-import { appendErrorStack, isNetworkError } from './generic';
+import { appendErrorStack } from './generic';
 import { workerFromCode } from './worker';
 
 const workerCode = function () {
@@ -239,18 +239,6 @@ const workerCode = function () {
         difference,
       });
     } catch (ex) {
-      if (
-        isNetworkError(ex) ||
-        ['InvalidStateError', 'SecurityError'].includes(ex?.name)
-      ) {
-        this.postMessage({
-          id,
-          baseUrl,
-          difference: 1,
-        });
-        return;
-      }
-
       this.postMessage({
         id,
         baseUrl,