fix: FrameConverter only copies upper square on portrait-format video #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be copying lines for the height of the image, not the width. Width happened to work since most test videos are landscape.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## 2.x #460 +/- ##
=========================================
Coverage 90.84% 90.84%
Complexity 6068 6068
=========================================
Files 660 660
Lines 15876 15876
Branches 1515 1515
=========================================
Hits 14422 14422
Misses 1410 1410
Partials 44 44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bradh
approved these changes
Mar 3, 2024
|
Looks like the QA failure is unrelated. Have proposed fix at #461. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FrameConverter should be copying lines for the height of the image, not the width. Width happened to work since most test videos are landscape.
Motivation and Context
Portrait videos do not play properly, only rendering the upper (width x width) part of the video.
Description
The change is a one-line fix in the FrameConverter's convert method where a decoded frame is put into a ByteBuffer.
How Has This Been Tested?
Tested on a few different portrait-format videos I had handy and on a set of landscape video I usually work with. Not extensively tested.
Screenshots (if appropriate):
Types of changes
Checklist: