Issue #65: Empty title added to untitled pages to address use-model i…

…ssue with quicknotes getting 'Untitled Page' as default title.
WetHat · Apr 25, 2022 · 4e0f8df · 4e0f8df
1 parent ed151f7
commit 4e0f8df
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 3 deletions.
diff --git a/OneNoteTaggingKit/PageBuilder/OneNotePage.cs b/OneNoteTaggingKit/PageBuilder/OneNotePage.cs
@@ -169,7 +169,11 @@ where t.TagType < PageTagType.HashTag
         /// </summary>
         /// <param name="onenoteApp">The OneNote application object.</param>
         /// <param name="pageID">The page ID.</param>
-        internal OneNotePage(OneNoteProxy onenoteApp, string pageID) : base(onenoteApp.GetPage(pageID).Root) {
+        /// <param name="defaultTitle">
+        ///     The default title to use if the page does not already have a title.
+        /// </param>
+        internal OneNotePage(OneNoteProxy onenoteApp, string pageID, string defaultTitle = "")
+            : base(onenoteApp.GetPage(pageID).Root) {
             OneNoteApp = onenoteApp;
             PageID = pageID;
             Document = Element.Document; // get the page's XML document
@@ -184,7 +188,7 @@ internal OneNotePage(OneNoteProxy onenoteApp, string pageID) : base(onenoteApp.G
             XElement title = Element.Element(GetName(nameof(Title)));
             if (title == null) {
                 // a title is required for tagging
-                Title = new Title(this, "Untitled Page");
+                Title = new Title(this, defaultTitle);
             } else {
                 Title = new Title(this, title);
                 // inspect the title tags an mark collect the managed oage tags

diff --git a/OneNoteTaggingKit/Properties/Resources.Designer.cs b/OneNoteTaggingKit/Properties/Resources.Designer.cs
diff --git a/OneNoteTaggingKit/Properties/Resources.resx b/OneNoteTaggingKit/Properties/Resources.resx
@@ -584,4 +584,7 @@ Tap or click link to navigate to page.</value>
   <data name="TaggingKit_Docs_Link" xml:space="preserve">
     <value>https://wethat.github.io/OnenoteTaggingKit/v4.0/Home.html</value>
   </data>
+  <data name="NewSavedSearchPage_Title" xml:space="preserve">
+    <value>Untitled Search</value>
+  </data>
 </root>
diff --git a/OneNoteTaggingKit/Properties/Resources.zh.resx b/OneNoteTaggingKit/Properties/Resources.zh.resx
@@ -584,4 +584,7 @@
   <data name="TaggingKit_Docs_Link" xml:space="preserve">
     <value>https://wethat.github.io/OnenoteTaggingKit/v4.0/Home.html</value>
   </data>
+  <data name="NewSavedSearchPage_Title" xml:space="preserve">
+    <value>无标题搜索</value>
+  </data>
 </root>
diff --git a/OneNoteTaggingKit/find/FindTaggedPages.xaml.cs b/OneNoteTaggingKit/find/FindTaggedPages.xaml.cs
@@ -205,7 +205,7 @@ private async void Page_MenuItem_Click(object sender, RoutedEventArgs e) {
                             } else {
                                 pBarCopy.Visibility = Visibility.Visible;
                                 var newPageID = onenote.CreateNewPage(onenote.CurrentSectionID);
-                                var pg = new PageBuilder.OneNotePage(onenote, newPageID);
+                                var pg = new PageBuilder.OneNotePage(onenote, newPageID, Properties.Resources.NewSavedSearchPage_Title);
                                 SearchScope scope = scopeSelect.SelectedScope;
                                 string searchstring = searchComboBox.Text;
                                 var tagset = new PageTagSet(from rt in ViewModel.SelectedRefinementTags.Values